Skip to content

Qualcomm AI Engine Direct - LLM 16bit CI fix#20478

Merged
psiddh merged 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/winskuo/fix_llm_ci_quant_range
Jul 7, 2026
Merged

Qualcomm AI Engine Direct - LLM 16bit CI fix#20478
psiddh merged 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/winskuo/fix_llm_ci_quant_range

Conversation

@winskuo-quic

@winskuo-quic winskuo-quic commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

#19660 has missed to identify quant range when a node uses shared quant annotation. Fix this issue by recursive search to the source node that shares the quant spec and use the source node's quant spec as quant range.

Test plan

Passing LLM 16bit CI

@pytorch-bot

pytorch-bot Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20478

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 01348dc with merge base 124b677 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2026
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/fix_llm_ci_quant_range branch from 82433c7 to a94f560 Compare June 26, 2026 03:37
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/fix_llm_ci_quant_range branch from a94f560 to 01348dc Compare July 6, 2026 02:30
@winskuo-quic winskuo-quic changed the title Qualcomm AI Engine Direct - Testing fix Qualcomm AI Engine Direct - LLM 16bit CI fix Jul 7, 2026
@winskuo-quic winskuo-quic marked this pull request as ready for review July 7, 2026 03:41
@winskuo-quic

winskuo-quic commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

@psiddh This PR should fix the CI 16bit LLM failure. Please have a look. Thanks

@psiddh psiddh merged commit a5455c4 into pytorch:main Jul 7, 2026
183 of 185 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psiddh psiddh psiddh approved these changes
@abhinaykukkadapu abhinaykukkadapu Awaiting requested review from abhinaykukkadapu abhinaykukkadapu is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@winskuo-quic @psiddh